lkml.org 
[lkml]   [2014]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL v2] liblockdep fixes for v3.14

* Sasha Levin <sasha.levin@oracle.com> wrote:

> The following changes since commit 65370bdf881e20907e7a53abab9b8c0bc5f60a6b:
>
> Merge branch 'linus' into core/locking (2014-02-02 09:43:20 +0100)

That's not a suitable base commit for upstream fixes (because it
brings in tip:core/locking changes destined for v3.15!) - please use
tip:core/urgent or one of Linus's -rc's.

Also, I found some more commit log problems.

1)

This:

Acked-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

Is redundant - skip the Acked-by.

2)

This:

[sasha: Modified subject]
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

should in general be:

[ Modified subject. ]
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

Because it's obvious from the placement of the bracketed line that the
comment is from you, no need to prefix it with 'sasha:'.

But ... more importantly, small commit log edits are typical (and
expected) from maintainers - I do it for 99% of the patches that I
apply, so please only add such comments if it goes outside the usual
pattern:

- if you've written a completely new changelog (nice from you)

- or if you've resolved conflicts when applying the patch or
actually changed the code logic compared to what was submitted
(which should always be declared).

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-02-22 19:01    [W:3.166 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site