lkml.org 
[lkml]   [2014]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] workqueue: Guarantee work function memory ordering
Hello, Peter.

On Sat, Feb 22, 2014 at 10:05:53AM -0500, Peter Hurley wrote:
> Given your concerns about the performance impact, maybe we should
> ask Fengguang to run this change through his automated test suites
> to find out what the perf delta is?

It should be fine. It's more like I just didn't like the idea of it.
Workqueue execution path isn't really light enough for an addition of
single smp_rmb() per work item execution makes any noticeable
difference. No harm in measuring perf delta but I'm highly skeptical
that there will be any difference which can be measured.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2014-02-22 17:21    [W:0.031 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site