Messages in this thread | | | Date | Sat, 22 Feb 2014 09:37:18 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v7 8/8] ARM: sunxi: Add documentation for driver for SD/MMC hosts found on Allwinner sunxi SoCs |
| |
Hi David,
On Sat, Feb 22, 2014 at 08:32:03AM +0100, David Lanzendörfer wrote: > > Ditto. Plus, this is not a mod0 clock. > Yes it is! But maybe the formulation hasn't been clear enough...
Technically, it's not, it has this phase controls features a mod0 clock doesn't have.
> > You never talked about the clock-names property, and which clocks > > were supposed to be provided. > > Yes I did? But I expanded the text a little bit further...
I can't see any reference to the fact that clock-names should be set, and what values should it hold.
Something like that: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.txt#n11
> > > + interrupts = <0 32 4>; > > > + bus-width = <4>; > > And you never talked about bus-width either. > I can throw in a line for refering to the mmc slot gpio lib docs.
Yes, that would be great :)
> > Isn't the cd-gpios property requested too? > I can refer to the docs there as well if you like... :-)
That would be great too :)
Thanks! Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |