Messages in this thread | | | Date | Sat, 22 Feb 2014 13:00:39 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH v2 2/2] x86: Support compiling out human-friendly processor feature names |
| |
On Sat, Feb 22, 2014 at 09:49:36PM +0100, Borislav Petkov wrote: > On Sat, Feb 22, 2014 at 11:57:10AM -0800, Josh Triplett wrote: > > diff --git a/arch/x86/boot/cpu.c b/arch/x86/boot/cpu.c > > index 6ec6bb6..29207f6 100644 > > --- a/arch/x86/boot/cpu.c > > +++ b/arch/x86/boot/cpu.c > > @@ -16,7 +16,9 @@ > > */ > > > > #include "boot.h" > > +#ifdef CONFIG_X86_FEATURE_NAMES > > #include "cpustr.h" > > +#endif > > You probably could get rid of this ifdef too by moving it into cpustr.h > after teaching arch/x86/boot/mkcpustr.c to issue it...
That would require building and running mkcpustr, which doesn't happen when !CONFIG_X86_FEATURE_NAMES. (And it'd require adding ifdefs to mkcpustr instead, which seems counterproductive.)
However, in exploring this, I ran into some build issues with v2 on a clean build; I'll send out v3 shortly with fixes to those.
- Josh Triplett
| |