Messages in this thread | | | Date | Fri, 21 Feb 2014 11:57:30 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK |
| |
Yo,
On Fri, Feb 21, 2014 at 11:53:46AM -0500, Peter Hurley wrote: > Ok, I can do that. But AFAIK it'll have to be an smp_rmb(); there is > no mb__after unlock.
We do have smp_mb__after_unlock_lock().
> [ After thinking about it some, I don't think preventing speculative > writes before clearing PENDING if useful or necessary, so that's > why I'm suggesting only the rmb. ]
But smp_mb__after_unlock_lock() would be cheaper on most popular archs, I think.
Thanks.
-- tejun
| |