lkml.org 
[lkml]   [2014]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute
From
On Fri, Feb 21, 2014 at 9:52 AM, Hannes Reinecke <hare@suse.de> wrote:
> On 02/21/2014 03:48 PM, Josh Boyer wrote:
>> On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>>> 3.13-stable review patch. If anyone has any objections, please let me know.
>>>
>>> ------------------
>>>
>>> From: Hannes Reinecke <hare@suse.de>
>>>
>>> commit d8a5dc3033af2fd6d16030d2ee4fbd073460fe54 upstream.
>>>
>>> The 'active' sysfs attribute should refer to the currently active tty
>>> devices the console is running on, not the currently active console.
>>>
>>> The console structure doesn't refer to any device in sysfs, only the tty
>>> the console is running on has. So we need to print out the tty names in
>>> 'active', not the console names.
>>>
>>> This resolves an issue on s390 platforms in determining the correct
>>> console device to use.
>>
>> Just to be double sure this is seen, Ray points out that it breaks
>> current plymouth because the heuristic changed. Hold off on this one?
>>
> Without this patch systemd won't present a login console for s390.
> I'd prefer fixing plymouth.

Sure. Except fixing plymouth is easy to do, but not easy to actually
get deployed on all of the old userspace. So if someone runs a 3.14
kernel on any distro that doesn't have a fixed plymouth, it's broken.
By including this patch, you're basically trading one broken userspace
component for another.

Is there some other way this could be fixed in-kernel that would allow
both to work?

josh


\
 
 \ /
  Last update: 2014-02-21 16:41    [W:0.106 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site