lkml.org 
[lkml]   [2014]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 047/121] xhci: Fix resume issues on Renesas chips in Samsung laptops
    Date
    3.11.10.5 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sarah Sharp <sarah.a.sharp@linux.intel.com>

    commit 1aa9578c1a9450fb21501c4f549f5b1edb557e6d upstream.

    Don Zickus <dzickus@redhat.com> writes:

    Some co-workers of mine bought Samsung laptops that had mostly usb3 ports.
    Those ports did not resume correctly (the driver would timeout communicating
    and fail). This led to frustration as suspend/resume is a common use for
    laptops.

    Poking around, I applied the reset on resume quirk to this chipset and the
    resume started working. Reloading the xhci_hcd module had been the temporary
    workaround.

    Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
    Reported-by: Don Zickus <dzickus@redhat.com>
    Tested-by: Prarit Bhargava <prarit@redhat.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/usb/host/xhci-pci.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
    index 32ef829..c1f6005 100644
    --- a/drivers/usb/host/xhci-pci.c
    +++ b/drivers/usb/host/xhci-pci.c
    @@ -137,6 +137,11 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
    xhci_dbg(xhci, "QUIRK: Resetting on resume\n");
    xhci->quirks |= XHCI_TRUST_TX_LENGTH;
    }
    + if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
    + pdev->device == 0x0015 &&
    + pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG &&
    + pdev->subsystem_device == 0xc0cd)
    + xhci->quirks |= XHCI_RESET_ON_RESUME;
    if (pdev->vendor == PCI_VENDOR_ID_VIA)
    xhci->quirks |= XHCI_RESET_ON_RESUME;
    }
    --
    1.9.0


    \
     
     \ /
      Last update: 2014-02-21 15:42    [W:4.352 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site