lkml.org 
[lkml]   [2014]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [tip:x86/asmlinkage] lto: Handle LTO common symbols in module loader
Date
tip-bot for Joe Mario <tipbot@zytor.com> writes:
> Commit-ID: 80375980f1608f43b47abc2671456b23ec68c434
> Gitweb: http://git.kernel.org/tip/80375980f1608f43b47abc2671456b23ec68c434
> Author: Joe Mario <jmario@redhat.com>
> AuthorDate: Sat, 8 Feb 2014 09:01:09 +0100
> Committer: H. Peter Anvin <hpa@linux.intel.com>
> CommitDate: Thu, 13 Feb 2014 20:24:50 -0800
>
> lto: Handle LTO common symbols in module loader
>
> Here is the workaround I made for having the kernel not reject modules
> built with -flto. The clean solution would be to get the compiler to not
> emit the symbol. Or if it has to emit the symbol, then emit it as
> initialized data but put it into a comdat/linkonce section.

Gah, as I said, fix the damn comment!

> case SHN_COMMON:
> + /* Ignore common symbols */
> + if (!strncmp(name, "__gnu_lto", 9))
> + break;
> +
> /* We compiled with -fno-common. These are not

/* Ignore common symbols */ is so bad, it's not even wrong.

Cheers,
Rusty.


\
 
 \ /
  Last update: 2014-02-21 04:21    [W:0.073 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site