Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Fri, 21 Feb 2014 09:55:28 +0800 | Subject | Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names |
| |
Hi,
On Fri, Feb 21, 2014 at 12:38 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 02/20/2014 05:51 AM, Heikki Krogerus wrote: >> There is no use for them in this driver. This will fix a >> static checker warning.. > > Didn't you remove the use: > > - gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0); > + gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0); > > doesn't that parameter get put into the sysfs GPIO debug file, so people > can see which GPIOs are used for what?
That's correct. However using con_id to pass this results in different behavior across DT and ACPI. A better way is to export the labeling function so consumers can set meaningful labels themselves.
Cheers ChenYu
| |