lkml.org 
[lkml]   [2014]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] regulator: tps65218: Add terminate entry for of_device_id table
On Tue, Feb 18, 2014 at 08:20:59PM +0800, Axel Lin wrote:
> Fixes below build error:
> FATAL: drivers/regulator/tps65218-regulator: struct of_device_id is not terminated with a NULL entry!

This is good (though I'm not seeing a build time error myself...).

> Also remove of_match_ptr as this is a DT-only driver.

This should really have been split out as a separate change. We
probably also need an OF dependency in the Kconfig for this (there may
be one on the MFD but having one here if the driver specficaly depends
on DT is better to avoid bisection issues if the MFD gets updated).
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-02-19 09:21    [W:0.144 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site