Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH 2/4] perf tools: Destroy unused symsrcs | Date | Thu, 20 Feb 2014 10:32:54 +0900 |
| |
Stephane reported that perf report and annotate failed to process data using lots of (> 500) shared libraries. It was because of the limit on number of open files (ulimit -n).
Currently when perf loads dso, it'll look for normal and dynamic symbol tables. And if it failed to find out both tables, it'll iterate all of possible symtab types. But many of them are useless since they have no additional information and the problem is that it's not close those files even though they're not used. Fix it.
Reported-by: Stephane Eranian <eranian@google.com> Cc: Cody P Schafer <cody@linux.vnet.ibm.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/util/symbol.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 46e2ede12c51..c3b014712fce 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -1336,6 +1336,8 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) if (syms_ss && runtime_ss) break; + } else { + symsrc__destroy(ss); } } -- 1.7.11.7
| |