lkml.org 
[lkml]   [2014]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] Sparc: sparc_cpu_model isn't in asm/system.h any more
From
From: David Howells <dhowells@redhat.com>
Date: Wed, 12 Feb 2014 15:45:59 +0000

> sparc_cpu_model isn't in asm/system.h any more, so remove a comment about it.
>
> Signed-off-by: David Howells <dhowells@redhat.com>

That's not all your patch does:

> - /* extern enum sparc_cpu sparc_cpu_model; */ /* in <asm/system.h> */
> - if (sparc_cpu_model != sun4m) {
> + if (sparc_cpu_model != sun4m)
> /* We must be on sun4m because we use MMU Bypass ASI. */
> return -ENXIO;
> - }

The basic block is more than one line, therefore the braces are
appropriate. Please do not remove them, and especially do not
remove them without mentioning them in the commit message.

Thanks.


\
 
 \ /
  Last update: 2014-02-20 02:41    [W:0.062 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site