Messages in this thread | | | Subject | Re: [PATCH] target_core_alua: silence GCC warning | From | "Nicholas A. Bellinger" <> | Date | Wed, 19 Feb 2014 14:59:09 -0800 |
| |
On Wed, 2014-02-19 at 11:05 +0100, Paul Bolle wrote: > On Wed, 2014-02-19 at 10:59 +0100, Geert Uytterhoeven wrote: > > On Wed, Feb 19, 2014 at 10:52 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > > > - ret = core_alua_state_nonoptimized(cmd, cdb, > > > - nonop_delay_msecs, &alua_ascq); > > > + core_alua_state_nonoptimized(cmd, cdb, nonop_delay_msecs); > > > > I suggest making core_alua_state_nonoptimized() return void, too. > > Currently it always returns zero. > > Good catch. Not sure how I missed that, since I deliberately ignore its > return value here. > > I'll wait with sending a v2 until after Nicholas or the other target > developers have given their feedback. > >
Hi Paul,
The patch is fine with me.. Feel free to post a -v2.
Thanks,
--nab
| |