lkml.org 
[lkml]   [2014]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] perf tools: Factor features display code
Em Wed, Feb 19, 2014 at 04:52:54PM +0100, Jiri Olsa escreveu:
> Currently the we display all detected features/libraries
> by following rules:
> - if one of the features is missing
> - if it's build from clean tree
>
> This patch changes changes this behavior in several ways.
>
> - We no longer display all detected features, only detected
> libraries are displayed by default:
>
> $ make
> BUILD: Doing 'make -j4' parallel build
>
> Auto-detecting system features:
> ... dwarf: [ on ]
> ... glibc: [ on ]
> ... gtk2: [ on ]
> ... libaudit: [ on ]
> ... libbfd: [ on ]
> ... libelf: [ on ]
> ... libnuma: [ on ]
> ... libperl: [ on ]
> ... libpython: [ on ]
> ... libslang: [ on ]
> ... libunwind: [ on ]

I like it, testing now, one suggestion: Since this is just about
libraries, ditch the "lib' prefix, and make the header more
informative, making it look like this:

Auto-detecting system libraries that enables features:
... dwarf: [ on ]
... c: [ on ]
... gtk2: [ on ]
... audit: [ on ]
... bfd: [ on ]
... elf: [ on ]
... numa: [ on ]
... perl: [ on ]
... python: [ on ]
... slang: [ on ]
... unwind: [ on ]

Also, do we look first for dwarf, then for glibc?

Back to the other patches...

- Arnaldo


\
 
 \ /
  Last update: 2014-02-19 23:41    [W:0.078 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site