lkml.org 
[lkml]   [2014]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Set bounds on what /proc/self/make-it-fail accepts.
On Wed, Feb 19, 2014 at 01:40:25PM -0800, Andrew Morton wrote:

> Switching `make_it_fail' to unsigned makes the test simpler but it does
> rather muck up the typing in there. task_struct.make_it_fail is still
> an int, we should now use simple_strtoul rather than simple_strtol,
> proc_fault_inject_read()'s snprintf() should now use %u, etc. None of
> which actually matters, but still...

I toyed with the idea of changing task_struct.make_it_fail to unsigned too,
but only realized I missed that after I'd sent out the diff.

> Rather than address all that I'm inclined to leave `make_it_fail' as an
> int, turning your patch into a one-liner?

That works for me too.

Dave



\
 
 \ /
  Last update: 2014-02-19 23:21    [W:0.063 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site