lkml.org 
[lkml]   [2014]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] hyperv: Add latest NetVSP versions to auto negotiation
From
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Tue, 18 Feb 2014 12:28:54 -0800

> + u32 ver_list[] = {NVSP_PROTOCOL_VERSION_1, NVSP_PROTOCOL_VERSION_2,
> + NVSP_PROTOCOL_VERSION_4, NVSP_PROTOCOL_VERSION_5};

Please put a space after "{" and before "}".

> + int i, num_ver = 4; /* number of different NVSP versions */
> +
>
> net_device = get_outbound_net_device(device);

Please delete the extraneous empty line.

> + for (i = num_ver - 1; i >= 0; i--)
> + if (negotiate_nvsp_ver(device, net_device, init_packet,
> + ver_list[i]) == 0) {

This is not indented properly, "ver_list[i])" should begin precisely after
the openning parenthesis of the negotiate_nvsp_ver() function call.



\
 
 \ /
  Last update: 2014-02-19 23:21    [W:0.030 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site