Messages in this thread | | | Date | Wed, 19 Feb 2014 17:24:40 -0300 | From | Emilio López <> | Subject | Re: [PATCH 0/4] clk: mvebu: fix clk init order |
| |
Hi Gregory,
El 18/02/14 06:47, Gregory CLEMENT escribió: (snip) > (...) what would be an acceptable > version would be the something like the patch attached. There will be still > an issue if old dtb is used with recent kernel, but at least the user will > be warned.
The patch you attached is similar in spirit to what I suggested, but with way more warnings sprinkled around. I don't really mind either way, and if you prefer big warnings so be it; it's your driver after all :-)
> This code only fix the Armada 370 case, a complete solution should modify > the dtsi for Armada XP, Armada 375, Armada 38x, Kirkwood and Dove. It should > also make the outputname mandatory for gate-clk for consistency.
Again, all of them are your calls. Fix the issue as you see fit; as long as it's a technically sound I'm ok with it. But please don't reinvent the wheel on framework code under a principle that has no proven reason to be to cover up for a buggy driver.
Cheers, and have a great Wednesday :)
Emilio
PS: I'd really appreciate it if you could keep me cc'ed on respins of patches I comment on in the future. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |