Messages in this thread | | | Date | Wed, 19 Feb 2014 14:08:31 +0530 | From | Keerthy <> | Subject | Re: [PATCH 2/3 v2] regulator: tps65218: Remove unnecessary regulator_unregister call |
| |
On Wednesday 19 February 2014 02:04 PM, Axel Lin wrote: > Current code uses devm_regulator_register() so the we don't need to explicitly > call regulator_unregister() in .remove. > And then we don't need to save rdev pointer to tps->rdev[id].
Acked-by: Keerthy <j-keerthy@ti.com>
> Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/regulator/tps65218-regulator.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c > index d1c7831..1fb1db5 100644 > --- a/drivers/regulator/tps65218-regulator.c > +++ b/drivers/regulator/tps65218-regulator.c > @@ -267,23 +267,6 @@ static int tps65218_regulator_probe(struct platform_device *pdev) > return PTR_ERR(rdev); > } > > - /* Save regulator */ > - tps->rdev[id] = rdev; > - > - return 0; > -} > - > -static int tps65218_regulator_remove(struct platform_device *pdev) > -{ > - struct tps65218 *tps = platform_get_drvdata(pdev); > - const struct of_device_id *match; > - const struct tps_info *template; > - > - match = of_match_device(tps65218_of_match, &pdev->dev); > - template = match->data; > - regulator_unregister(tps->rdev[template->id]); > - platform_set_drvdata(pdev, NULL); > - > return 0; > } > > @@ -294,7 +277,6 @@ static struct platform_driver tps65218_regulator_driver = { > .of_match_table = of_match_ptr(tps65218_of_match), > }, > .probe = tps65218_regulator_probe, > - .remove = tps65218_regulator_remove, > }; > > module_platform_driver(tps65218_regulator_driver);
| |