lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] pfuze100-regulator: Revert "regulator: pfuze100: Use of_get_child_by_name"
From
On 19 February 2014 07:42, Shawn Guo <shawn.guo@linaro.org> wrote:
> On Tue, Feb 18, 2014 at 09:58:52PM +0530, Sachin Kamat wrote:
>> On 18 February 2014 21:20, Fabio Estevam <fabio.estevam@freescale.com> wrote:
>> > Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
>> > the following probe failure:
>> >
>> > pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
>> > pfuze100-regulator 1-0008: FAB: 0, FIN: 0
>> > pfuze100-regulator 1-0008: regulators node not found
>> > pfuze100-regulator: probe of 1-0008 failed with error -22
>> >
>> > Revert the offending commit so that we can probe the regulator successfully.
>>
>> I wonder what is different in this case from the ones that I already
>> have working
>> that is causing this to fail. Can you please tell me which dts file
>> you have used
>> so that I can see if the way the node is defined is anything different.
>
> When you change to use of_get_child_by_name(), you should change 'np' to
> point to dev->of_node too.

Thanks for the tip Shawn. Coincidentally all the ones that I tested
had this (np pointing
to dev->of_node) already. So I happened to miss out on this check.

--
With warm regards,
Sachin


\
 
 \ /
  Last update: 2014-02-19 05:01    [W:0.055 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site