lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 13/21] perf, c2c: Add callchain support
On Tue, Feb 18, 2014 at 02:07:31PM +0100, Jiri Olsa wrote:
> On Mon, Feb 10, 2014 at 12:29:08PM -0500, Don Zickus wrote:
> > Seeing cacheline statistics is useful by itself. Seeing the callchain
> > for these cache contentions saves time tracking things down.
> >
> > This patch tries to add callchain support. I had to use the generic
> > interface from a previous patch to output things to stdout easily.
> >
> > Other than the displaying the results, collecting the callchain and
> > merging it was fairly straightforward.
> >
> > I used a lot of copying-n-pasting from other builtin tools to get
> > the intial parameter setup correctly and the automatic reading of
> > 'symbol_conf.use_callchain' from the data file.
> >
> > Hopefully this is all correct. The amount of memory corruption (from the
> > callchain dynamic array) seems to have dwindled done to nothing. :-)
>
> hum.. report command already has all this.. if we could go the
> hist_entry way, there'd be no need to reiplement this

Sure. I will look into the hist_entry. It would also be nice if the
callchain support had a better api so those commands that can't hook in
through hist_entry had a simpler way to utilize callchains. :-)

Cheers,
Don


\
 
 \ /
  Last update: 2014-02-19 04:42    [W:0.241 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site