Messages in this thread | | | Date | Tue, 18 Feb 2014 18:22:24 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH -mm 2/3] mm,numa: reorganize change_pmd_range |
| |
On Tue, 18 Feb 2014, riel@redhat.com wrote:
> From: Rik van Riel <riel@redhat.com> > > Reorganize the order of ifs in change_pmd_range a little, in > preparation for the next patch. > > Signed-off-by: Rik van Riel <riel@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Reported-by: Xing Gang <gang.xing@hp.com> > Tested-by: Chegu Vinod <chegu_vinod@hp.com>
Acked-by: David Rientjes <rientjes@google.com>
> --- > mm/mprotect.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 769a67a..6006c05 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -118,6 +118,8 @@ static inline unsigned long change_pmd_range(struct vm_area_struct *vma, > unsigned long this_pages; > > next = pmd_addr_end(addr, end); > + if (!pmd_trans_huge(*pmd) && pmd_none_or_clear_bad(pmd)) > + continue; > if (pmd_trans_huge(*pmd)) { > if (next - addr != HPAGE_PMD_SIZE) > split_huge_page_pmd(vma, addr, pmd);
Extra tab there, though.
| |