lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
From
2014-02-18 18:05 GMT+09:00, Lukáš Czerner <lczerner@redhat.com>:
> On Wed, 12 Feb 2014, Namjae Jeon wrote:
>
>> Date: Wed, 12 Feb 2014 11:28:35 +0900
>> From: Namjae Jeon <linkinjeon@gmail.com>
>> To: Lukáš Czerner <lczerner@redhat.com>
>> Cc: viro@zeniv.linux.org.uk, david@fromorbit.com, bpm@sgi.com,
>> tytso@mit.edu,
>> adilger.kernel@dilger.ca, jack@suse.cz, mtk.manpages@gmail.com,
>> linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
>> linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
>> Namjae Jeon <namjae.jeon@samsung.com>,
>> Ashish Sangwan <a.sangwan@samsung.com>
>> Subject: Re: [PATCH RESEND 3/10] ext4: Add support
>> FALLOC_FL_COLLAPSE_RANGE
>> for fallocate
>>
>> 2014-02-11 20:59 GMT+09:00, Lukáš Czerner <lczerner@redhat.com>:
>> > On Sun, 2 Feb 2014, Namjae Jeon wrote:
>> >
>> >> Date: Sun, 2 Feb 2014 14:44:34 +0900
>> >> From: Namjae Jeon <linkinjeon@gmail.com>
>> >> To: viro@zeniv.linux.org.uk, david@fromorbit.com, bpm@sgi.com,
>> >> tytso@mit.edu,
>> >> adilger.kernel@dilger.ca, jack@suse.cz, mtk.manpages@gmail.com
>> >> Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
>> >> linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
>> >> Namjae Jeon <linkinjeon@gmail.com>, Namjae Jeon
>> >> <namjae.jeon@samsung.com>,
>> >> Ashish Sangwan <a.sangwan@samsung.com>
>> >> Subject: [PATCH RESEND 3/10] ext4: Add support
>> >> FALLOC_FL_COLLAPSE_RANGE
>> >> for
>> >> fallocate
>> >>
>> >> From: Namjae Jeon <namjae.jeon@samsung.com>
>> >>
>> >> Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
>> Hi Lukas.
>> >
>> > Description is missing here, please provide FALLOC_FL_COLLAPSE_RANGE
>> > description so people know what it's supposed to be doing.
>> >
>> > more comments bellow.
>> Okay, I will udpate.
>> >
>> > Thanks!
>> > -Lukas
>
> Hi,
Hi Lukas.
>
> you may have noticed my patches for new FALLOC_FL_ZERO_RANGE
> fallocate flag. This changes things around the same area as your
> patches does so we should probably figure out which are going to
> land in first and then rebase the other on top of that.
Yes, I have seen your patches. I think that VFS + XFS patches for
FALLOC_FL_COLLAPSE_RANGE have got a fair amount of review from Dave.
So they are almost ready. I will post collapse range v5 patches after
fixing some minor comments tonight or tommorow.
If there will be no more comments for XFS patch, VFS + XFS patches can
go through to xfs tree by Dave.
I think that Ext4 collapse range could go at a later time.(Need your
reviewed-by tag)
If still there are comments for xfs patch, I will rebase on top of your patch.
>
> One concern I have is that I have not seen any tests provided to
> verify the feature. But I just may have missed it. Do you have any
> xfstests test or at least fsx and fsstress patches to provide
> support for testing FALLOC_FL_COLLAPSE_RANGE ? Patches for
> util_linux might also be handy.
Yes, There are 5 new xfstests cases in this patch-set. these will also
be posted with collapse range patch-set soon.

Thanks :)
>
> Thanks!
> -Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-02-18 11:41    [W:0.094 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site