| From | Greg Kroah-Hartman <> | Subject | [PATCH 3.13 35/40] pinctrl: imx27: fix offset calculation in imx_read_2bit | Date | Tue, 18 Feb 2014 14:47:36 -0800 |
| |
3.13-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
commit e3365d0974ed64157f5b5a576c611057dc40a595 upstream.
The offset for the 2bit register calculate wrong, this patch fixes the problem. The debugfs printout for oconf, iconfa, iconfb now shows the real values.
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> Reviewed-by: Markus Pargmann <mpa@pengutronix.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/pinctrl/pinctrl-imx1-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/pinctrl/pinctrl-imx1-core.c +++ b/drivers/pinctrl/pinctrl-imx1-core.c @@ -139,7 +139,7 @@ static int imx1_read_2bit(struct imx1_pi u32 reg_offset) { void __iomem *reg = imx1_mem(ipctl, pin_id) + reg_offset; - int offset = pin_id % 16; + int offset = (pin_id % 16) * 2; /* Use the next register if the pin's port pin number is >=16 */ if (pin_id % 32 >= 16)
|