lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix flags for initramfs LZ4 compression
On Sat, 15 Feb 2014 18:14:57 -0500 "Daniel M. Weeks" <dan@danweeks.net> wrote:

> LZ4 as implemented in the kernel differs from the default method now
> used by the reference implementation of LZ4. Until the in-kernel method
> is updated to support the new default, passing the legacy flag (-l) to
> the compressor is necessary. Without this flag the kernel-generated,
> LZ4-compressed initramfs is junk.
>
> ...
>
> --- a/scripts/gen_initramfs_list.sh
> +++ b/scripts/gen_initramfs_list.sh
> @@ -257,7 +257,7 @@ case "$arg" in
> && compr="lzop -9 -f"
> echo "$output_file" | grep -q "\.lz4$" \
> && [ -x "`which lz4 2> /dev/null`" ] \
> - && compr="lz4 -9 -f"
> + && compr="lz4 -l -9 -f"
> echo "$output_file" | grep -q "\.cpio$" && compr="cat"
> shift
> ;;

What happens is the user is running an old version of /bin/lz4? A
version which predates this switch to a new format? Do those earlier
versions accept -l, even though they don't need it? Or will the kernel
build fail?



\
 
 \ /
  Last update: 2014-02-19 01:41    [W:0.048 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site