lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/3] usb: chipidea: msm: Add device tree binding information
    On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote:
    > From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
    >
    > Document device tree binding information as required by
    > the Qualcomm USB controller.
    >
    > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
    > ---
    > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++

    Although you mentioned to Josh that this is intended for "non-standard"
    Chipidea properties, I don't see any other than requiring that 'dr_mode'
    must be "peripheral". It would seem that this should all be integrated
    into a ci3xxx.txt.

    > 1 file changed, 17 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
    > index 5ea26c6..d4e7e41 100644
    > --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt
    > +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
    > @@ -15,3 +15,20 @@ Example EHCI controller device node:
    > usb-phy = <&usb_otg>;
    > };
    >
    > +CI13xxx (Chipidea) USB controllers
    > +
    > +Required properties:
    > +- compatible: should contain "qcom,ci-hdrc"

    Is there nothing more specific you could put here? Maybe a hardware
    revision, or something?

    > +- reg: offset and length of the register set in the memory map
    > +- interrupts: interrupt-specifier for the controller interrupt.
    > +- usb-phy: phandle for the PHY device
    > +- dr_mode: Sould be "peripheral"

    s/Sould/should/

    -Courtney


    \
     
     \ /
      Last update: 2014-02-18 23:41    [W:4.279 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site