lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)
From
On Mon, Feb 17, 2014 at 10:45 PM, Kent Overstreet <kmo@daterainc.com> wrote:
> *swears* Actually, I'm just going to cast this to unsigned (that's definitely
> safe here):
>
>
> commit 70bc49d421c793f73a772ae1f50622a39c6136d9
> Author: Kent Overstreet <kmo@daterainc.com>
> Date: Mon Feb 17 13:44:06 2014 -0800
>
> bcache: Fix another compiler warning on m68k

JFYI, you also get this warning on other 32-bit platforms (e.g. ARM).

> Use a bigger hammer this time

Looks like it's big enough, now ;-)

> Signed-off-by: Kent Overstreet <kmo@daterainc.com>
>
> diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
> index 3f74b4b074..5454164153 100644
> --- a/drivers/md/bcache/bset.c
> +++ b/drivers/md/bcache/bset.c
> @@ -23,8 +23,8 @@ void bch_dump_bset(struct btree_keys *b, struct bset *i, unsigned set)
> for (k = i->start; k < bset_bkey_last(i); k = next) {
> next = bkey_next(k);
>
> - printk(KERN_ERR "block %u key %li/%u: ", set,
> - (uint64_t *) k - i->d, i->keys);
> + printk(KERN_ERR "block %u key %u/%u: ", set,
> + (unsigned) ((u64 *) k - i->d), i->keys);
>
> if (b->ops->key_dump)
> b->ops->key_dump(b, k);

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2014-02-18 10:41    [W:0.082 / U:2.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site