lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT Pull] timer fixes for 3.14
On Tue, 18 Feb 2014, Preeti Murthy wrote:

> Hi Thomas,
>
> With regard to the patch: "tick: Clear broadcast pending bit when
> switching to oneshot"
> isn't BROADCAST_EXIT called atleast after initializing the high
> resolution timers while
> handling the broadcast IPI and before re-entering idle? This should
> clear the cpu bit
> in the pending mask right?
>
> idle()
> |__BROADCAST_ENTER
> |__halt()
> |__broadcast_ipi
> |__init_highres()->clear oneshot mask
> |__return from interrupt->BROADCAST_EXIT (clear pending mask)

Unfortunately not:

if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_oneshot_mask)) {
clear pending mask;
}

> |__re-enter idle

Go figure :)

Thanks,

tglx


\
 
 \ /
  Last update: 2014-02-18 20:21    [W:0.051 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site