| Date | Tue, 18 Feb 2014 10:49:44 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 02/21] perf c2c: Dump raw records, decode data_src bits |
| |
Em Tue, Feb 18, 2014 at 01:53:35PM +0100, Jiri Olsa escreveu: > On Mon, Feb 10, 2014 at 12:28:57PM -0500, Don Zickus wrote: > > From: Arnaldo Carvalho de Melo <acme@redhat.com> <SNIP> > > +static int perf_c2c__process_load_store(struct perf_c2c *c2c, > > + struct perf_sample *sample, > > + struct addr_location *al) > > +{ > > + if (c2c->raw_records) > > + perf_sample__fprintf(sample, ' ', "raw input", al, stdout); > > + > > return 0; > > }
> > static const struct perf_evsel_str_handler handlers[] = { > > - { "cpu/mem-loads,ldlat=30/pp", perf_c2c__process_load, }, > > - { "cpu/mem-stores/pp", perf_c2c__process_store, }, > > + { "cpu/mem-loads,ldlat=30/pp", perf_c2c__process_load_store, }, > > + { "cpu/mem-stores/pp", perf_c2c__process_load_store, },
> hm.. so it's only one function for both handlers.. no need > to use handlers at all then, right?
This was just an skeleton from where to continue, so no, the idea isn't to have just one function for both.
- Arnaldo
|