lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] iio: adc: Add MEN 16z188 ADC driver
On top of what Peter said. Just some nitpicks...
[...]
> +static struct iio_chan_spec z188_adc_iio_channels[] = {

const

> + Z188_ADC_CHANNEL(0),
> + Z188_ADC_CHANNEL(1),
> + Z188_ADC_CHANNEL(2),
> + Z188_ADC_CHANNEL(3),
> + Z188_ADC_CHANNEL(4),
> + Z188_ADC_CHANNEL(5),
> + Z188_ADC_CHANNEL(6),
> + Z188_ADC_CHANNEL(7),
> +};
> +
[...]
> +static struct iio_info z188_adc_info = {

const

> + .read_raw = &z188_iio_read_raw,
> + .driver_module = THIS_MODULE,
> +};

> +
> +static void men_z188_remove(struct mcb_device *dev)
> +{
[...]
> + mcb_set_drvdata(dev, NULL);

This is already done by the device driver core.

> +}
[...]
> +static struct mcb_device_id men_z188_ids[] = {

const

> + { .device = 0xbc },
> +};
> +MODULE_DEVICE_TABLE(mcb, men_z188_ids);


\
 
 \ /
  Last update: 2014-02-18 17:21    [W:2.351 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site