lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4 v2] Staging: comedi: addi-data: convert printk() to dev_err()
On 2014-02-18 06:34, Chase Southwood wrote:
> This patch for hwdrv_apci035.c changes a printk() call to a dev_err() call
> since this is generally preferred. It also removes a newline from the start
> of the error message.
>
> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
> ---
> 2: Removed leading newline, per Ian's request.
>
> drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
> index 90d5801..ff64540 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
> @@ -227,7 +227,7 @@ static int i_APCI035_ConfigTimerWatchdog(struct comedi_device *dev,
> ui_Command = ui_Command & 0xFFF819E2UL;
>
> } else {
> - printk("\n The parameter for Timer/watchdog selection is in error\n");
> + dev_err(dev->class_dev, "The parameter for Timer/watchdog selection is in error\n");
> return -EINVAL;
> }
> }
>

That's better!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-


\
 
 \ /
  Last update: 2014-02-18 14:01    [W:0.152 / U:1.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site