Messages in this thread Patch in this message | | | Date | Tue, 18 Feb 2014 15:03:46 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] kernel/groups.c: remove return value of set_groups |
| |
On Sun, 16 Feb 2014 23:31:07 +0800 Wang YanQing <udknight@gmail.com> wrote:
> After commit 6307f8fee295b364716d28686df6e69c2fee751a > ("security: remove dead hook task_setgroups"), set_groups > will always return zero, so we could just remove return > value of set_groups. > > This patch reduce code size, and simplfy code logician > to use set_groups, because we don't need to check its > return value anymore. >
Looks OK. We should also update the set_groups() description to reflect reality.
--- a/kernel/groups.c~kernel-groupsc-remove-return-value-of-set_groups-fix +++ a/kernel/groups.c @@ -157,9 +157,6 @@ int groups_search(const struct group_inf * set_groups - Change a group subscription in a set of credentials * @new: The newly prepared set of credentials to alter * @group_info: The group list to install - * - * Validate a group subscription and, if valid, insert it into a set - * of credentials. */ void set_groups(struct cred *new, struct group_info *group_info) { _
| |