lkml.org 
[lkml]   [2014]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH tip/core/rcu 15/55] rcutorture: Abstract rcu_torture_random()
On Mon, Feb 17, 2014 at 02:12:19PM -0800, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
>
> Because rcu_torture_random() will be used by the locking equivalent to
> rcutorture, pull it out into its own module.
>
> Suggested-by: Rusty Russell <rusty@rustcorp.com.au>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

I'd suggest making CONFIG_TORTURE_TEST a completely invisible option,
with no description; it should only be brought in via "select".

Also, it doesn't need most of the headers it currently includes.

Have you considered moving it into the existing random generation
infrastructure, as something like "fast_insecure_nonblocking_random"?
That seems more generally useful.

- Josh Triplett


\
 
 \ /
  Last update: 2014-02-18 01:41    [W:0.371 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site