Messages in this thread | | | Date | Mon, 17 Feb 2014 15:37:48 +0000 | From | One Thousand Gnomes <> | Subject | Re: [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers |
| |
> #define TIOCSFIFORTRIG _IOW('T', 0x41, unsigned char) > > > Also, why pass a pointer to a variable, and not just the value itself? > > Ah, it's no big reason. > It will pass just the value itself in V2.
We don't need ioctls here - we have a sysfs interface we can expand to do this. We also need proper locking. This isn't a trivial change but its perfectly doable given a real world use case.
> According to a manual of setserial command, we could set RX interrupt > trigger only for the Hayes ESP serial driver. However, current kernel > does not support Hayes ESP serial[1]. I couldn't find this feature for > current 8250/16X50 drivers.
It is long gone and was a set of ugly device specific hacks.
Alan
| |