Messages in this thread | | | Date | Mon, 17 Feb 2014 14:20:48 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH v2 7/9] HID: remove hid_get_raw_report in struct hid_device |
| |
On Mon, 17 Feb 2014, Benjamin Tissoires wrote:
> >> diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c > >> index f5a2b19..12439e1 100644 > >> --- a/drivers/hid/uhid.c > >> +++ b/drivers/hid/uhid.c > >> @@ -404,7 +404,6 @@ static int uhid_dev_create(struct uhid_device *uhid, > >> hid->uniq[63] = 0; > >> > >> hid->ll_driver = &uhid_hid_driver; > >> - hid->hid_get_raw_report = uhid_hid_get_raw; > > > > I'll queue a followup patch on top of this that completely removes > > uhid_hid_get_raw(), as it's unused now. > > Jiri, please don't. It was a mistake which was fixed in the next patch > series (2/14: HID: uHID: implement .raw_request). It was already > reviewed by David, so you can apply it right now.
Yeah, I just came to the same conclusion during review as we speak. I will sort it out.
Thanks.
-- Jiri Kosina SUSE Labs
| |