lkml.org 
[lkml]   [2014]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI
On Sun, 16 Feb 2014, Paul Bolle wrote:

> USB_ARCH_HAS_EHCI, USB_ARCH_HAS_OHCI, and USB_ARCH_HAS_XHCI were made
> obsolete in v3.11. They have not been used ever since. Setting them has
> no effect. They can safely be removed.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested with "git grep".
>
> Note that the comment in this Kconfig file (that is also removed)
> suggests to first remove the select statements for these symbols and
> then the symbols themselves. But I think it makes more sense to first
> delete these three symbols and then remove the selects statements (as
> that is removing a second order effect). But it could just as well be
> done with just one patch, I'd say.

There's a simple reason for not getting rid of the symbols first.
Doing it that way, as you did, leaves a window in which it's possible
to select a non-existent symbol. If that's not an error, it ought to
be.

Regardless, for both patches:

Acked-by: Alan Stern <stern@rowland.harvard.edu>

Alan Stern



\
 
 \ /
  Last update: 2014-02-16 21:41    [W:0.022 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site