lkml.org 
[lkml]   [2014]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] printk: Fix discarding of records
On 2/16/14, 7:41 PM, "Linus Torvalds" <torvalds@linux-foundation.org>
wrote:

>On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata
><dbanerje@akamai.com> wrote:
>>
>> No that can't be right, the prev value after every loop is the
>>msg->flags
>> from the *last* line in the list, which has no relation to the *first*,
>>so
>> reusing it for the top of the next loop is nonsense.
>
>Please, Debabrata, humor me, and just try the patch.
>
>And try reading the source code. Because your statement is BS.
...
>No, I haven't tested my patch, and maybe it's broken for some subtle
>reason I'm missing too.

Yes my explanation was wrong, your patch works for me. I assumed printing
the prefix was desired, but if not, great.

-Debabrata




\
 
 \ /
  Last update: 2014-02-17 04:21    [W:0.058 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site