Messages in this thread | | | Date | Sat, 15 Feb 2014 16:03:45 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH V2 11/17] i2c: nomadik: Convert to devm functions |
| |
On Thu, Feb 13, 2014 at 03:09:02PM +0100, Ulf Hansson wrote: > Use devm_* functions to simplify code and error handling. > > Cc: Alessandro Rubini <rubini@unipv.it> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Wolfram Sang <wsa@the-dreams.de> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > > Changes in v2: > Rebased on top of latest i2c-nomadik branch.
Since this depends on Linus' patch already, I think it would be cleaner if I pick this kinda unrelated (but wanted) devm patch, and ack the PM stuff. If this for some reason makes things more complicated, I can also simply ack this one.
> - dev->virtbase = ioremap(adev->res.start, resource_size(&adev->res)); > + dev->virtbase = devm_ioremap(&adev->dev, adev->res.start, > + resource_size(&adev->res)); > if (!dev->virtbase) { > ret = -ENOMEM;
IS_ERR()!
[unhandled content-type:application/pgp-signature] | |