Messages in this thread | | | Date | Sat, 15 Feb 2014 08:03:31 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] sched/deadline: Fix bad accounting of nr_running |
| |
On Sat, 15 Feb 2014 10:52:07 +0100 Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Feb 14, 2014 at 11:59:46PM -0500, Steven Rostedt wrote: > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > index 0dd5e09..84c2454 100644 > > --- a/kernel/sched/deadline.c > > +++ b/kernel/sched/deadline.c > > @@ -844,14 +844,14 @@ static void __dequeue_task_dl(struct rq *rq, > > struct task_struct *p, int flags) { > > dequeue_dl_entity(&p->dl); > > dequeue_pushable_dl_task(rq, p); > > + > > + dec_nr_running(rq); > > } > > > > static void dequeue_task_dl(struct rq *rq, struct task_struct *p, int > > flags) { > > update_curr_dl(rq); > > __dequeue_task_dl(rq, p, flags); > > - > > - dec_nr_running(rq); > > } > > > > /* > > That patch is so line-wrapped... tskk!
Damn it, That's claws mail. It inserts files (patches) fine, but if you go and modify something, it decides to "autowrap" the entire file. That's one of the things I need to fix when I get the time (I've downloaded the source as this frustrates the hell out of me). The autowrapping is the thing that I hate most about this client.
I'll send out a new patch later :-/
-- Steve
| |