Messages in this thread | | | Date | Sat, 15 Feb 2014 11:15:59 -0800 | From | Greg KH <> | Subject | Re: [PATCHv3 6/6] mailbox: move the internal definitions into a private file |
| |
On Sat, Feb 15, 2014 at 11:57:02PM +0530, Jassi Brar wrote: > From: Suman Anna <s-anna@ti.com> > > This is needed for extracting the omap_mbox. The OMAP mailbox > code has a need for exporting some pre-existing API to not > break the current clients. > > Signed-off-by: Suman Anna <s-anna@ti.com> > ---
You don't agree with this patch and sign off on it?
> drivers/mailbox/mailbox.c | 62 +----------------------------- > drivers/mailbox/mailbox_internal.h | 77 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 78 insertions(+), 61 deletions(-) > create mode 100644 drivers/mailbox/mailbox_internal.h
Why not just do this in the first patch(s)? Why wait for later in the series to "fix" things up?
thanks,
greg k-h
| |