Messages in this thread | | | Date | Sat, 15 Feb 2014 16:27:37 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH] i2c: designware-pci: Add Baytrail PCI IDs |
| |
On Tue, Feb 04, 2014 at 04:31:19PM +0200, Mika Westerberg wrote: > Intel Baytrail I2C controllers can be enumerated from PCI as well as from > ACPI. In order to support this add the Baytrail PCI IDs to the driver. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Basically fine, one question:
> - snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci-%d", > - adap->nr); > + > + if (adap->nr < 0) > + snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci"); > + else > + snprintf(adap->name, sizeof(adap->name), > + "i2c-designware-pci-%d", adap->nr);
Maybe we just drop the "-%d" suffix entirely?
[unhandled content-type:application/pgp-signature] | |