Messages in this thread | | | Date | Thu, 13 Feb 2014 13:54:32 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe() |
| |
On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: > On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: > >Do not write configuration data in probe(), we have config() for that. > > Then we should call config() in rmi_function_probe() to ensure that > any platform data or device tree configuration settings get written > to the device.
Well, yes, we may elect to update device configuration in probe, but then we should not be doing that 2nd time in ->config(). We shoudl pick either one or another.
Thanks.
-- Dmitry
| |