Messages in this thread |  | | Subject | Re: [PATCH] spi: core: Validate lenght of the transfers in message | From | "Ivan T. Ivanov" <> | Date | Fri, 14 Feb 2014 10:16:05 +0200 |
| |
On Fri, 2014-02-14 at 00:26 +0000, Mark Brown wrote: > On Thu, Feb 13, 2014 at 10:27:57PM +0100, Gerhard Sittig wrote: > > On Thu, Feb 13, 2014 at 16:46 +0200, Ivan T. Ivanov wrote: > > > > SPI transfer lenght should be a power-of-two multiple > > > of eight bits. > > > Are you suggesting that an SPI transfer cannot consist of e.g. > > three bytes? This would be surprising, and certainly would be > > rather wrong an assumption. Am I missing/misunderstanding > > something? > > The check is supposed to be verifying that the transfer is a whole > number of the current SPI word size as I understand it (not actually > looked at the change yet but that's where it came from, factored out of > a driver).
Yes. Comment is not correct. Is this better?
"SPI transfer length should be multiple of SPI word size, where SPI word size should be power-of-two multiple"
Regards, Ivan
|  |