[lkml]   [2014]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check
On Fri, Feb 14, 2014 at 10:50:23PM +0100, Levente Kurusa wrote:
> Since MSR_AP is 0x3, ANDing it with 0xFC will never be true.
> Add a NOT operation to 0xFC so that we will AND with the last
> three bits which will result in a possibility that the condition
> will succeed.
> Signed-off-by: Levente Kurusa <>
> ---
> Hi,
> This might not be the real solution since it is also possible that
> the particular condition never really happens. I seek comments
> so that I can post the proper patch.

I can't test it either but I think your fix is correct.

Reviewed-by: Dan Carpenter <>

dan carpenter

 \ /
  Last update: 2014-02-14 23:41    [W:0.039 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site