Messages in this thread |  | | Date | Fri, 14 Feb 2014 14:18:41 -0600 | From | Christoph Lameter <> | Subject | [PATCH 00/48] percpu: Consistent per cpu operations V4 |
| |
Can we please get this merged? The first patch alone would at least define the functions required to enable the merging of the rest in any order and through any tree.
There is a git tree that can be pulled at
https://git.kernel.org/cgit/linux/kernel/git/christoph/percpu.git/
It has the following branches:
minimal Just the first 5 patches to get the preemption checks going most All the conversion but not the removal of functionality in 47/48 all All these patches
V3->V4: - Rediff patches - Put the patches first that define the new API. - Add patches to convert the __get_cpu_var stuff added in 3.14
V2->V3: - Rediff patches - Fix breakage caused by mips patches. Add a mips patch to convert from local_t. - Update some descriptions.
V1->V2: - Move legacy definition for __this_cpu_ptr into include/asm-generic/percpu.h so that users bypassing include/linux/percpu.h do not break (affects tile and s390) - Merge raw_cpu_ops core and the patch to rename x86 __this_cpu primitives into one. Otherwise breakage will occur since x86 __this_cpu ops will fall back to generic ops which is not tolerated well by the preempt hackery in x86. - Add notes to each patch that depends on another to avoid mismerges. Add acks etc. - Use quilt-0.61 with the bug fix that ensures all mailing lists receive the postings intended for them.
The kernel has never been audited to ensure that this_cpu operations are consistently used throughout the kernel. The code generated in many places can be improved through the use of this_cpu operations (which uses a segment register for relocation of per cpu offsets instead of performing address calculations).
The patch set also addresses various consistency issues in general with the per cpu macros.
A. The semantics of __this_cpu_ptr() differs from this_cpu_ptr only because checks are skipped. This is typically shown through a raw_ prefix. So this patch set changes the places where __this_cpu_ptr() is used to raw_cpu_ptr().
B. There has been the long term wish by some that __this_cpu operations would check for preemption. However, there are cases where preemption checks need to be skipped. This patch set adds raw_cpu operations that do not check for preemption and then adds preemption checks to the __this_cpu operations.
C. The use of __get_cpu_var is always a reference to a percpu variable that can also be handled via a this_cpu operation. This patch set replaces all uses of __get_cpu_var with this_cpu operations.
D. We can then use this_cpu RMW operations in various places replacing sequences of instructions by a single one.
E. The use of this_cpu operations throughout will allow other arches than x86 to implement optimized references and RMV operations to work with per cpu local data.
F. The use of this_cpu operations opens up the possibility to further optimize code that relies on synchronization through per cpu data.
The patch set works in a couple of stages:
I. Patch 1 adds the additional raw_cpu operations and raw_cpu_ptr(). Also converts the existing __this_cpu_xx_# primitive in the x86 code to raw_cpu_xx_#.
II. Patch 2-4 use the raw_cpu operations in places that would give us false positives once they are enabled.
III. Patch 5 adds preemption checks to __this_cpu operations to allow checking if preemption is properly disabled when these functions are used.
IV. Patches 6-20 are patches that simply replace uses of __get_cpu_var with this_cpu_ptr. They do not depend on any changes to the percpu code. No preemption tests are skipped if they are applied.
V. Patches 21-46 are conversion patches that use this_cpu operations in various kernel subsystems/drivers or arch code.
VI. Patches 47/48 remove no longer used functions (__this_cpu_ptr and __get_cpu_var). These should only be applied after all the conversion patches have made it and after we have done additional passes through the kernel to ensure that none of the uses of these functions remain.
|  |