| Date | Fri, 14 Feb 2014 13:31:28 -0500 (EST) | Subject | Re: [PATCH v2 51/52] net/core/flow.c: Fix CPU hotplug callback registration | From | David Miller <> |
| |
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> Date: Fri, 14 Feb 2014 13:30:43 +0530
> Subsystems that want to register CPU hotplug callbacks, as well as perform > initialization for the CPUs that are already online, often do it as shown > below: ... > This is wrong, since it is prone to ABBA deadlocks involving the > cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently > with CPU hotplug operations). > > Instead, the correct and race-free way of performing the callback > registration is: ... > Fix the code in net/core/flow.c by using this latter form of callback > registration. > > Cc: Li RongQing <roy.qing.li@gmail.com> > Cc: Sasha Levin <sasha.levin@oracle.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Chris Metcalf <cmetcalf@tilera.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: netdev@vger.kernel.org > Signed-off-by: David S. Miller <davem@davemloft.net> > Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: David S. Miller <davem@davemloft.net>
|