Messages in this thread Patch in this message | | | From | Joonsoo Kim <> | Subject | [PATCH v2 5/5] mm/compaction: clean-up code on success of ballon isolation | Date | Fri, 14 Feb 2014 15:54:03 +0900 |
| |
It is just for clean-up to reduce code size and improve readability. There is no functional change.
Acked-by: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
diff --git a/mm/compaction.c b/mm/compaction.c index 56536d3..a1a9270 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -553,11 +553,7 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, if (unlikely(balloon_page_movable(page))) { if (locked && balloon_page_isolate(page)) { /* Successfully isolated */ - cc->finished_update_migrate = true; - list_add(&page->lru, migratelist); - cc->nr_migratepages++; - nr_isolated++; - goto check_compact_cluster; + goto isolate_success; } } continue; @@ -609,13 +605,14 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, VM_BUG_ON(PageTransCompound(page)); /* Successfully isolated */ - cc->finished_update_migrate = true; del_page_from_lru_list(page, lruvec, page_lru(page)); + +isolate_success: + cc->finished_update_migrate = true; list_add(&page->lru, migratelist); cc->nr_migratepages++; nr_isolated++; -check_compact_cluster: /* Avoid isolating too much */ if (cc->nr_migratepages == COMPACT_CLUSTER_MAX) { ++low_pfn; -- 1.7.9.5
| |