Messages in this thread |  | | Date | Fri, 14 Feb 2014 15:08:25 +0100 | Subject | Re: [PATCH] hwmon: twl4030-madc-hwmon: Add device tree support. | From | Belisko Marek <> |
| |
On Fri, Feb 14, 2014 at 2:31 PM, Mark Rutland <mark.rutland@arm.com> wrote: > On Fri, Feb 14, 2014 at 01:20:58PM +0000, Marek Belisko wrote: >> Signed-off-by: Marek Belisko <marek@goldelico.com> >> --- >> Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt | 9 +++++++++ >> drivers/hwmon/twl4030-madc-hwmon.c | 10 ++++++++++ >> 2 files changed, 19 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt >> >> diff --git a/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt b/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt >> new file mode 100644 >> index 0000000..e8016d1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt >> @@ -0,0 +1,9 @@ >> +TWL4030 MADC hwmon. >> + >> +Required properties: >> +- compatible: "ti,twl4030-madc-hwmon" >> + >> +Example: >> +madc-hwmon { >> + compatible = "ti,twl4030-madc-hwmon"; >> +}; > > Huh? > > What is this a binding for? From a look at the driver in mainline this > just calls into functions from the twl4030 madc driver (which doesn't > seem to have a binding). I post bindings for twl4030-madc [1]. Without probing this driver other things will not work (twl4030-madc-battery e.g.). Is there better way to handle this situation? > > This doesn't look like a description of hardware, but rather a hack to > get a Linux driver to probe. As far as I can see, no useful information > is given by this binding. > > Thanks, > Mark.
BR,
marek
-- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com
|  |