lkml.org 
[lkml]   [2014]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/asmlinkage] lto: Handle LTO common symbols in module loader
    Commit-ID:  80375980f1608f43b47abc2671456b23ec68c434
    Gitweb: http://git.kernel.org/tip/80375980f1608f43b47abc2671456b23ec68c434
    Author: Joe Mario <jmario@redhat.com>
    AuthorDate: Sat, 8 Feb 2014 09:01:09 +0100
    Committer: H. Peter Anvin <hpa@linux.intel.com>
    CommitDate: Thu, 13 Feb 2014 20:24:50 -0800

    lto: Handle LTO common symbols in module loader

    Here is the workaround I made for having the kernel not reject modules
    built with -flto. The clean solution would be to get the compiler to not
    emit the symbol. Or if it has to emit the symbol, then emit it as
    initialized data but put it into a comdat/linkonce section.

    Minor tweaks by AK over Joe's patch.

    Cc: Rusty Russell <rusty@rustcorp.com.au>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Link: http://lkml.kernel.org/r/1391846481-31491-5-git-send-email-ak@linux.intel.com
    Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
    ---
    kernel/module.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/kernel/module.c b/kernel/module.c
    index d24fcf2..b99e801 100644
    --- a/kernel/module.c
    +++ b/kernel/module.c
    @@ -1948,6 +1948,10 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)

    switch (sym[i].st_shndx) {
    case SHN_COMMON:
    + /* Ignore common symbols */
    + if (!strncmp(name, "__gnu_lto", 9))
    + break;
    +
    /* We compiled with -fno-common. These are not
    supposed to happen. */
    pr_debug("Common symbol: %s\n", name);

    \
     
     \ /
      Last update: 2014-02-14 06:21    [W:4.169 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site