Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Thu, 13 Feb 2014 15:41:25 +0800 | Subject | Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices |
| |
On Tue, Feb 11, 2014 at 3:17 AM, Arend van Spriel <arend@broadcom.com> wrote: > The Broadcom bcm43xx sdio devices are fullmac devices that may be > integrated in ARM platforms. Currently, the brcmfmac driver for > these devices support use of platform data. This patch specifies > the bindings that allow this platform data to be expressed in the > devicetree. > > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Reviewed-by: Hante Meuleman <meuleman@broadcom.com> > Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com> > Signed-off-by: Arend van Spriel <arend@broadcom.com> > --- > This devicetree binding proposal is intended for platforms with > Broadcom wireless device in MMC sdio slot. These devices may > have their own interrupt and power line. Also the SDIO drive > strength is often hardware dependent and expressed in this > binding.
Hi,
I believe the interrupts and drive-strength properties are Ok. However, letting the platform driver power up the wifi chip does not guarantee proper ordering, does it? I mean, what if the MMC bus was probed before the (non-removable) chip was switched on?
Being able to tie that to the mmc controller would be better IMO. I think this was discussed in Olof's "mmc: add support for power-on sequencing through DT" thread.
Thanks! ChenYu
> > Not sure if this should go in staging or not. Feel free to > comment on this proposal. > > Regards, > Arend
| |