Messages in this thread |  | | From | Heiko Stübner <> | Subject | Re: [PATCH] regulator: gpio-regulator: fix forgotten gpios-states reading | Date | Thu, 13 Feb 2014 20:17:54 +0100 |
| |
Am Donnerstag, 13. Februar 2014, 19:03:22 schrieb Mark Brown: > On Thu, Feb 13, 2014 at 12:48:52AM +0100, Heiko Stübner wrote: > > From: Heiko Stuebner <heiko.stuebner@bqreaders.com> > > > > Commit 934624d6e9f0 ("regulator: gpio-regulator: do not open-code counting > > and access of dt array elements") forgot to convert the recently added > > gpios-states property using the same pattern. > > Morimoto-san sent a fix which did apply so I took that.
The gpio-state code also uses the pattern, that we're trying to remove (open- coding dt element counting and exposing dtb internals, aka be32_to_cpup).
So reintroducing the "struct property" fixes the compile issue but does not resolve the underlying issue we're trying to improve.
So I would argue for removing this commit again in favor of my v2 sent 16:34.
Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |